feat: option to disable/enable buckets #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julusian
reviewed
Nov 18, 2024
Collaborator
Julusian
left a comment
Julusian
left a comment
There was a problem hiding this comment.
Github is reporting some typings errors somewhere
I think it would be good to add a 'hint' (<span className="text-s dimmed field-hint">) after the setting field to indicate that this new setting just affects the ui, and doesn't stop any bucket behaviour.
Alternatively, it would make sense for sofie to reject any bucket operations performed for this studio. But that is a lot more fiddlier work, and I think that this being just a ui change is fine
Julusian
approved these changes
Nov 20, 2024
Julusian
changed the title
Julusian
pushed a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an Enable Buckets option in settings, so it's possible to completely disable Buckets.
A migration has been added where this setting is default true to support previous core versions.